Skip to content

chore(EventBuilder): remove reserved event validation #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lindsey-volta merged 3 commits into from
Oct 7, 2025
Merged

chore(EventBuilder): remove reserved event validation #2263

lindsey-volta merged 3 commits into from
Oct 7, 2025

Conversation

@lindsey-volta
Copy link
Contributor

@lindsey-volta lindsey-volta commented Oct 3, 2025 •
edited
Loading

Remove the client-side validation for reserved event names in the Event Builder.

  • This check is redundant, as Measurement Protocol's /debug endpoint already performs this validation.
  • Prevents duplicate error messages from being shown to the user, improving user experience by providing a single, clear error message from the backend.
  • Reduces maintenance and ensures the tool is always enforcing accurate checks.

Screenshots

 User only shown one validation error message if they try to incorrectly send a reserved event: image

Whereas previously, since the validation was happening locally and on the server side, the user saw duplicate messages.
image

@lindsey-volta lindsey-volta changed the title chore(EventBuilder): Remove reserved event validation chore(EventBuilder): remove reserved event validation Oct 3, 2025
lindsey-volta
lindsey-volta commented Oct 3, 2025
View reviewed changes
@lindsey-volta lindsey-volta marked this pull request as ready for review October 3, 2025 20:27
@lindsey-volta lindsey-volta merged commit f94e627 into main Oct 7, 2025
7 checks passed
@lindsey-volta lindsey-volta deleted the reserved-event-validation branch October 7, 2025 17:17
appletorsh19-stack referenced this pull request Nov 3, 2025
@lindsey-volta
feat(EventBuilder): allow in_app_purchase events for app streams (#2265)
8776698 
* allow in app purchase events for app streams

* increase jest timeout

* add comment explanation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jradcliff jradcliff jradcliff approved these changes

@ikuleshov ikuleshov ikuleshov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lindsey-volta @jradcliff @ikuleshov